On Wed, 12 Jan 2011 03:56:33 -0000, Martin Pool <email address hidden> wrote:
> It seems to me the underlying thing here is not especially udd-specific:
> if the hook generates a suggested commit message, it's reasonable for
> the user to just accept it without modification. Generally speaking if
> they exit the editor without changing it, I think we should just accept
> it.
ISTR that I requested the confirmation be added, because of the
bzr-builddeb hook.
Before the hook simply closing the editor without saving cancelled the
commit, and after it caused the commit to go ahead.
It may just be because I was familiar with the old method (and cancel a
lot of commits when I see what --show-diff says), and new users wouldn't
find this a problem.
On Wed, 12 Jan 2011 03:56:33 -0000, Martin Pool <email address hidden> wrote:
> It seems to me the underlying thing here is not especially udd-specific:
> if the hook generates a suggested commit message, it's reasonable for
> the user to just accept it without modification. Generally speaking if
> they exit the editor without changing it, I think we should just accept
> it.
ISTR that I requested the confirmation be added, because of the
bzr-builddeb hook.
Before the hook simply closing the editor without saving cancelled the
commit, and after it caused the commit to go ahead.
It may just be because I was familiar with the old method (and cancel a
lot of commits when I see what --show-diff says), and new users wouldn't
find this a problem.
Thanks,
James