Comment 5 for bug 605067

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> On 14 July 2010 10:57, John A Meinel <email address hidden> wrote:
>> Isn't the original fix for this setting "append_revisions_only" on the
>> trunk? (Preventing this sort of behavior).
>
> That would prohibit uncommits. Perhaps it is reasonable to want
> explicit uncommits but not changing the mainline.
>

It does, but if you prevent getting there in the first place, you might
be okay.

Uncommit is pretty dangerous on a trunk that people integrate around,
since suddenly a revision in the history disappears, and everyone has to
figure out how to resync.

Given the nature of it, is there a problem making it 2-phase?

1) Unset the append_revisions_only flag, indicating that for the next
bit it is okay to mutate history a bit.
2) Uncommit
3) set append_revisions_only back to True.

I think not having that automated is a reasonable tradeoff between being
possible, and shooting yourself in the foot by doing it accidentally.

However, we certainly need to make it easier to set (and unset) the
append_revisions_only flag.

John
=;->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkw+urkACgkQJdeBCYSNAAOUIACeIW+/KcYrzUurM3GZGKYSV+OB
h/AAoLZV7Zj3IPlmlzAKzMX8uBz+Vzg+
=G0yA
-----END PGP SIGNATURE-----