> Wrapping in try/finally is what I tried, which indeed doesn't really
> feel like right thing. Also problematic are that this is in
> bzrlib.transport.http._urllib so presumably pycurl will need some kind
> of change as well,
Well, pycurl there is kind of a blackbox and you need to provide the
credentials in the url. pycurl just can't prompt either.
> and this looks a pain to test.
Nope, all the hard work has already been done in test_http.py, all the
tests auth are parametrized for all http implementations (and then
some).
> Think it really wants a blackbox style test to ensure the console
> interactions are sane, but doing that across http libraries and
> authentication methods, which avoiding leaking server threads,
> looks complicated.
Either it's fixed after the leaking-tests proposal is landed or before
but in both cases taking care of leaks is out of scope ;)
It would be simpler to fix it after the landing though, so I've added
the relevant tags.
Status confimed and importance medium are appropriate IMHO, but patches
welcome !
>>>>> Martin [gz] <email address hidden> writes:
> Wrapping in try/finally is what I tried, which indeed doesn't really transport. http._urllib so presumably pycurl will need some kind
> feel like right thing. Also problematic are that this is in
> bzrlib.
> of change as well,
Well, pycurl there is kind of a blackbox and you need to provide the
credentials in the url. pycurl just can't prompt either.
> and this looks a pain to test.
Nope, all the hard work has already been done in test_http.py, all the
tests auth are parametrized for all http implementations (and then
some).
> Think it really wants a blackbox style test to ensure the console
> interactions are sane, but doing that across http libraries and
> authentication methods, which avoiding leaking server threads,
> looks complicated.
Either it's fixed after the leaking-tests proposal is landed or before
but in both cases taking care of leaks is out of scope ;)
It would be simpler to fix it after the landing though, so I've added
the relevant tags.
Status confimed and importance medium are appropriate IMHO, but patches
welcome !