Comment 9 for bug 507557

Revision history for this message
Gareth White (gwhite-deactivatedaccount) wrote :

Robert Collins wrote:
> We need it when deleting content so that two processes don't try to
> delete the same file at the same time.

In that case, I wonder if we should also be doing the renaming within the lock too. Even if we skip renaming files that we find are already in "obsolete_packs", there's still a chance that two processes will try to rename a file at the same time. It will have to either ignore NoSuchFile when renaming or do it within a lock too.