Comment 9 for bug 506196

On Tue, 2010-01-12 at 06:17 +0000, Martin Pool wrote:
> 2010/1/12 Andrew Bennetts <email address hidden>:
> > Jelmer Vernooij wrote:
> > [...]
> >> Yeah, if there is no .bzr/format file then it makes no sense to do a
> >> POST request I think. I'm not very familiar with the smart client, so
> >> I'm not sure how feasible this is.
> >
> > Well, POST to .bzr/smart can work when there's no .bzr/branch-format in
> > some cases, so I'm not sure that's right. e.g. consider something like
> > 'bzr log $branch_url/README'. That said it's probably reasonable in
> > principle to try GET .bzr/branch-format before POST .bzr/smart, but I
> > fear it'll be pretty awkward in the existing code :/
>
> I think a probe for .bzr should not hurt much, and should work with
> any plausible server setup, and should fit in reasonably easily. It's
> true it's an unnecessary roundtrip, but there's probably more
> important fat we could trim.

On particularly locked down servers, checking for .bzr will fail when a
post to .bzr/smart works : we've encountered this in the past. Skipping
the .bzr probe isn't a performance thing per se: its correctness.

-Rob