Comment 2 for bug 50329

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 50329] Re: [Bug 50329] commit code requires plugins to be loaded

On Mon, 2006-06-19 at 13:01 +0000, John A Meinel wrote:
> Jelmer Vernooij wrote:
> > Public bug reported:
> >
> > Current bzr.dev will bail out if it's being used from an external
> > application that doesn't load bzrs plugins. The commit code will throw a
> > confusing exception in the post_commit code if this happens.
> >
> > We should skip plugins if none are loaded or make sure there's at least
> > always an empty list there.
> Post_commit only runs whatever you have configured to run. (in
> ~/.bazaar/bazaar.conf).
> If you tell it to run a post-commit action (this doesn't have to be from
> a plugin), then it should fail with a reasonable error message saying
> that it couldn't perform the action you requested it to do.
Ah, right. Sorry. So I guess this bug is actually the fact that we don't
throw an exception that makes sense if the post_commit hook can't be
found. Related to that is the fact that plugins can't register
post_commit hooks at the moment, but you have to specify them yourself.

Cheers,

Jelmer
--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/