Comment 4 for bug 449923

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Andrew Bennetts wrote:
>> A couple of thoughts:
>
>> - Some --diff-options, like -p, would produce semantically equivalent
>> diffs that bzr would parse ok. So if bzr generated the diff with
>> --diff-options and then checked that it still validates like a regular
>> diff would, then that could be useful.
>
> The validation is text-based. If you don't generate the same text as
> bzr itself would generate, validation will fail. It doesn't matter how
> it parses. If we did use the parser to parse a -p-style diff, it would
> fail, because our parser only parses vanilla unified diffs.

It's also worth mentioning that while the diffs would describe the same
result, they would not describe the delta in the same way, because
/usr/bin/diff doesn't use the patience algorithm for matching.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrYuM0ACgkQ0F+nu1YWqI3DqACeKlxqIiicOjOoO+aWMPYowU0o
FtwAn0SmEfPOjqd6qhFhJwG4cj3MVgAm
=yCn6
-----END PGP SIGNATURE-----