Comment 2 for bug 440062

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
>> === modified file 'bzrlib/commands.py'
>> - --- bzrlib/commands.py 2009-06-19 09:06:56 +0000
>> +++ bzrlib/commands.py 2009-10-01 15:59:00 +0000
>> @@ -1090,7 +1090,7 @@
>>
>> # Is this a final release version? If so, we should suppress warnings
>> if bzrlib.version_info[3] == 'final':
>> - - suppress_deprecation_warnings(override=False)
>> + suppress_deprecation_warnings(override=True)
>> if argv is None:
>> argv = osutils.get_unicode_argv()
>> else:
>
> It seems reasonable to me. I don't recall why we do that - perhaps for
> testing.
>
>

So #1 we need to figure out any implications with running "python
- -Werror bzr selftest", so that make check will properly fail if we get
deprecation warnings.

#2 I think I wrote override=False because if a user custom configured
their environment to do something specific with DeprecationWarnings, I
didn't want to step on their toes. I guess I didn't expect a python
stdlib module to suppress its own deprecation warnings...

So in the balance of things, I think override=True will be better for users.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrE6QsACgkQJdeBCYSNAAM88QCfbwBFZt+dZZYvQGMnhaIg8IM6
L4IAoJjT8bOIOgADHonWmhaEpTc9/w89
=HoST
-----END PGP SIGNATURE-----