On Tue, 2011-03-29 at 17:31 +0000, Samuel Bronson wrote:
> I don't suppose it would help to subclass NotBranchError, or that there
> is a way to pass it a better error message?
Yeah, that's ideally how this should be fixed - and it's what we do in
some other situations already. However, bzr currently catches NotBranchError and
displays a custom error message, ignoring the message in the exception.
> (I'm a bit surprised that bzr-svn doesn't just do the wrong thing,
> considering the sloppy way SVN handles branches!)
We could do that, but we don't want to encourage people to do the wrong
thing (and then e.g. complain about bzr-svn performance).
On Tue, 2011-03-29 at 17:31 +0000, Samuel Bronson wrote:
> I don't suppose it would help to subclass NotBranchError, or that there
> is a way to pass it a better error message?
Yeah, that's ideally how this should be fixed - and it's what we do in
some other situations already. However, bzr currently catches NotBranchError and
displays a custom error message, ignoring the message in the exception.
> (I'm a bit surprised that bzr-svn doesn't just do the wrong thing,
> considering the sloppy way SVN handles branches!)
We could do that, but we don't want to encourage people to do the wrong
thing (and then e.g. complain about bzr-svn performance).
Cheers,
Jelmer