Comment 9 for bug 402652

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 402652] Re: smart fetch for --2a does not opportunistically combine groups

On Mon, 2009-08-31 at 20:25 +0000, John A Meinel wrote:
>
>
> I think we should explicitly test it again. IIRC it is non trivial. I
> don't remember how long 'bzr pack' takes in a Launchpad tree, but that
> is exactly what you would be doing on the initial branch. Which seems
> very wasteful if the source is already mostly/completely packed.

doing a full pack took 11m35 on a branch of db-devel a couple of weeks
old.

> I *would* probably like to extract all the texts and check their
> sha1sums. But you can extract texts at about 400MB/s+, and sha1sum at
> about 60MB/s. Compression is much much slower than that.

yup. Its just that I've looked at the code and the problem is the
heuristic about whether to make a new group needs the text size, but to
get the text size we extract the text.

I'm going to do some measurements: just extracting always would be the
_simplest_ way forward, also solve the fragmentation thing better than
unordered does (because its still not combining separate pushes to the
source repo), and we can land reuse in a more polished form later.

-Rob