bzr gci crashes on Hardy w gtk from lp:~vila/bzr-gtk/385191-new-pb

[Sven Sandberg]

With the current bzr.dev and bzr.gtk, I suffer from https://bugs.launchpad.net/bzr/+bug/385191, so I use bzr-gtk from lp:~vila/bzr-gtk/385191-new-pb . This crashes with another stack trace when I run bzr gci. I'm using Ubuntu Hardy and have the package python-gtksourceview2 installed.

How to repeat:

$ cd ~/.bazaar/plugins
$ rm -rf gtk
$ bzr branch lp:~vila/bzr-gtk/385191-new-pb gtk
$ bzr gci
/home/sven/bzr/bzr/bzr.dev/bzrlib/util/bencode.py:22: DeprecationWarning: bzrlib.util.bencode was deprecated in version 1.16.
  Use bzrlib.bencode instead
  symbol_versioning.warn(dep_warning, DeprecationWarning)
bzr: ERROR: exceptions.AttributeError: 'gtksourceview2.LanguageManager' object has no attribute 'guess_language'

Traceback (most recent call last):
  File "/home/sven/bzr/bzr/bzr.dev/bzrlib/commands.py", line 729, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/home/sven/bzr/bzr/bzr.dev/bzrlib/commands.py", line 924, in run_bzr
    ret = run(*run_argv)
  File "/home/sven/bzr/bzr/bzr.dev/bzrlib/commands.py", line 560, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/home/sven/.bazaar/plugins/gtk/commands.py", line 296, in run
    dlg = CommitDialog(wt)
  File "/home/sven/.bazaar/plugins/gtk/commit.py", line 135, in __init__
    self.construct()
  File "/home/sven/.bazaar/plugins/gtk/commit.py", line 294, in construct
    self._construct_right_pane()
  File "/home/sven/.bazaar/plugins/gtk/commit.py", line 354, in _construct_right_pane
    self._construct_diff_view()
  File "/home/sven/.bazaar/plugins/gtk/commit.py", line 529, in _construct_diff_view
    self._diff_view = DiffView()
  File "/home/sven/.bazaar/plugins/gtk/diff.py", line 234, in __init__
    DiffFileView.__init__(self)
  File "/home/sven/.bazaar/plugins/gtk/diff.py", line 59, in __init__
    self.construct()
  File "/home/sven/.bazaar/plugins/gtk/diff.py", line 69, in construct
    gsl = slm.guess_language(content_type="text/x-patch")
AttributeError: 'gtksourceview2.LanguageManager' object has no attribute 'guess_language'

bzr 1.17dev on python 2.5.2 (linux2)
arguments: ['/home/sven/bin/bd', 'gci']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
  danny_plugins /home/sven/.bazaar/plugins/danny_plugins [unknown]
  difftools /home/sven/.bazaar/plugins/difftools [0.91]
  extmerge /home/sven/.bazaar/plugins/extmerge [unknown]
  gtk /home/sven/.bazaar/plugins/gtk [0.96.0.dev.1]
  launchpad /home/sven/bzr/bzr/bzr.dev/bzrlib/plugins/launchpad [1.17dev]
  mysql_merge /home/sven/.bazaar/plugins/mysql_merge [0.1]
  mysql_plugins /home/sven/.bazaar/plugins/mysql_plugins [0.4.2]
  netrc_credential_store /home/sven/bzr/bzr/bzr.dev/bzrlib/plugins/netrc_credential_store [1.17dev]
  per_file_remerge /home/sven/.bazaar/plugins/per_file_remerge [unknown]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

$ bzr version
Bazaar (bzr) 1.15
  Python interpreter: /usr/bin/python 2.5.2
  Python standard library: /usr/lib/python2.5
  bzrlib: /usr/lib/python2.5/site-packages/bzrlib
  Bazaar configuration: /home/sven/.bazaar
  Bazaar log file: /home/sven/.bzr.log

Copyright 2005, 2006, 2007, 2008, 2009 Canonical Ltd.
http://bazaar-vcs.org/

bzr comes with ABSOLUTELY NO WARRANTY. bzr is free software, and
you may use, modify and redistribute it under the terms of the GNU
General Public License version 2 or later.

$ bzr plugins -v
danny_plugins
    Danny's Plugins
    /home/sven/.bazaar/plugins/danny_plugins

difftools 0.91
    External diff tools plugin for Bazaar
    /home/sven/.bazaar/plugins/difftools

extmerge
    external merge plugin for bzr
    /home/sven/.bazaar/plugins/extmerge

gtk 0.96.0.dev.1
    Graphical support for Bazaar using GTK.
    /home/sven/.bazaar/plugins/gtk

launchpad 1.15
    Launchpad.net integration plugin for Bazaar.
    /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad

mysql_merge 0.1
    A merge algorithm which behaves like MySQL expects.
    /home/sven/.bazaar/plugins/mysql_merge

mysql_plugins 0.4.2
    MySQL/Sun org workflow helpers
    /home/sven/.bazaar/plugins/mysql_plugins

netrc_credential_store 1.15
    Use ~/.netrc as a credential store for authentication.conf.
    /usr/lib/python2.5/site-packages/bzrlib/plugins/netrc_credential_store

per_file_remerge
    Recompute a merge, using the per-file graph.
    /home/sven/.bazaar/plugins/per_file_remerge

$ uname -a
Linux riska 2.6.24-24-generic #1 SMP Wed Apr 15 15:54:25 UTC 2009 i686 GNU/Linux

$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=8.04
DISTRIB_CODENAME=hardy
DISTRIB_DESCRIPTION="Ubuntu 8.04.2"

[Vincent Ladeuil (vila)]

This is related to bug #385191 only because it masked that bug.

It can't be reproduced on jaunty.
Evidence points to bzr-gtk 635.2.6 revid:<email address hidden>

I don't have an hardy system to reproduce and diagnose further.

[Vincent Ladeuil (vila)]

Applying:
=== modified file 'diff.py'
--- diff.py 2009-05-26 13:53:30 +0000
+++ diff.py 2009-06-12 14:41:06 +0000
@@ -24,6 +24,7 @@
     have_gtksourceview = True
 except ImportError:
     have_gtksourceview = False
+have_gtksourceview = False
 try:
     import gconf
     have_gconf = True

addressed sven problem.

We obviously need a better fix, but since I can't reproduce the bug...

[Curtis Hovey (sinzui)]

GtkSourceView now using Gtk3.