poolie: spiv, if i thought there would be more cases then i'd do the object
poolie: is that the package in a distro?
spiv: If the underlying objects weren't private to the SmartMedium classes, that would be a pretty strong case for decorating.
spiv: poolie: right.
poolie: it's true it's more than 3 cases, strictly speaking
poolie: maybe i'll propose just this for now
spiv: poolie: So, I'm happy with the patch as is. If you feel like writing the decorator I'm happy to look at that page too :)
spiv: But it's not a big deal to postpone that refactoring indefinitely.
poolie: spiv, if i thought there would be more cases then i'd do the object
poolie: is that the package in a distro?
spiv: If the underlying objects weren't private to the SmartMedium classes, that would be a pretty strong case for decorating.
spiv: poolie: right.
poolie: it's true it's more than 3 cases, strictly speaking
poolie: maybe i'll propose just this for now
spiv: poolie: So, I'm happy with the patch as is. If you feel like writing the decorator I'm happy to look at that page too :)
spiv: But it's not a big deal to postpone that refactoring indefinitely.
https:/ /code.edge. launchpad. net/~mbp/ bzr/341535- eintr/+ merge/11029