2009/7/14 Nils Durner <email address hidden>:
> Hi,
>
> the attached patch adds a fallback to GET + PUT if APPE fails.
> Tested against Twisted 8.2.0 FTP Server.
Hi Nils,
Thanks for the patch. Could you please put it in a branch on
Launchpad and create a merge proposal so that we can review and track
it?
The patch looks reasonable to me. In some cases this may be a lot
slower so we should at least write a warning to the user the first
time this happens.
It would be nice to add a test that it works correctly, using our test
suite's medusa ftp server. I wouldn't strictly insist on having one
but at least adding a TODO to the test file would be good.
2009/7/14 Nils Durner <email address hidden>:
> Hi,
>
> the attached patch adds a fallback to GET + PUT if APPE fails.
> Tested against Twisted 8.2.0 FTP Server.
Hi Nils,
Thanks for the patch. Could you please put it in a branch on
Launchpad and create a merge proposal so that we can review and track
it?
The patch looks reasonable to me. In some cases this may be a lot
slower so we should at least write a warning to the user the first
time this happens.
It would be nice to add a test that it works correctly, using our test
suite's medusa ftp server. I wouldn't strictly insist on having one
but at least adding a TODO to the test file would be good.
-- launchpad. net/~mbp/>
Martin <http://