I think the general fix is to just make cmd_pull.run() use AtomicFile when it wants to change the contenst of .bzr/x-pull.
But there has also been some discussion between myself and Aaron Bentley (I think on the mailing list), that we don't actually want to change the contents of x-pull. Because from common use, it seems that most times a new location is the temporary one, not a permanent one.
Do you feel that "bzr pull <location>" should always override .bzr/x-pull, or only create it if it doesn't exist?
I think the general fix is to just make cmd_pull.run() use AtomicFile when it wants to change the contenst of .bzr/x-pull.
But there has also been some discussion between myself and Aaron Bentley (I think on the mailing list), that we don't actually want to change the contents of x-pull. Because from common use, it seems that most times a new location is the temporary one, not a permanent one.
Do you feel that "bzr pull <location>" should always override .bzr/x-pull, or only create it if it doesn't exist?