Comment 1 for bug 213182

Revision history for this message
Martin Pool (mbp) wrote :

Notes:

A problem here is that the tests should be observing static events in a deterministic way, rather than trying to measure them in real time.

I think we can test that more easily if we add interfaces saying "I failed to get the lock", "I'm going to sleep waiting for the lock" and then we can just test them in isolation -- both the default implementation and also as a point to hook in for more testing. This should help other UIs that want different reporting while waiting for locks or to override the policy.

Open questions: wait_lock currently takes parameters saying how long to wait and how often to try - are these still needed if not used from the test suite?

If the UI wants to override these methods, presumably it would want to do so across all locks. Should it just patch them into the LockDir class?