vila пишет:
> You're right, the first one is due to trace.enable_default_logging() and
> the second one to commands._setup_outf().
>
> The most disturbing thing IMHO is that get_terminal_encoding() has a
> side-effect which actually modifies the terminal encoding even if the
> function is prefixed with 'get_'.
No, I disagree, there is no side-effects. Only mutter twice mutters.
And waste of time, because every time encoding is checked for validity.
I guess caching will help, and I have branch with such change. But global
caching is sucks for tests.
vila пишет: default_ logging( ) and _setup_ outf(). encoding( ) has a
> You're right, the first one is due to trace.enable_
> the second one to commands.
>
> The most disturbing thing IMHO is that get_terminal_
> side-effect which actually modifies the terminal encoding even if the
> function is prefixed with 'get_'.
No, I disagree, there is no side-effects. Only mutter twice mutters.
And waste of time, because every time encoding is checked for validity.
I guess caching will help, and I have branch with such change. But global
caching is sucks for tests.