Comment 10 for bug 193253

Revision history for this message
Jonathan Lange (jml) wrote :

Hi Stuart,

I've just had a look at this. The client side of the connection is established by Branch.open in assertMirrored. Bazaar doesn't provide an API for closing this connection.

Given that Bazaar's behaviour is correct and that the test is using it sanely, I can think of three options:
- Fiddle with the Bazaar internals
- Run the test HTTP server in a subprocess and kill it when we are done
- Change the socket-leaking check

I'm leaning towards the third option. Like I said, Bazaar is working fine and we are using their API correctly, so it feels a bit backwards to have to "fix" it.

Thoughts?