Comment 4 for bug 174055

Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 174055] Re: can't run bzr info while dirstate is locked

On Dec 5, 2007 5:52 PM, Alexander Belchenko <email address hidden> wrote:
> I reported about this many times in the list and even file the bug
> report month ago: https://bugs.launchpad.net/bzr/+bug/158596
>
> Here the changes to test suite to reveal the problem on Linux:
>
> === modified file 'bzrlib/tests/blackbox/test_info.py'
> --- bzrlib/tests/blackbox/test_info.py 25.10.2007 7:57:32
> +++ bzrlib/tests/blackbox/test_info.py 30.10.2007 12:15:11
> @@ -1136,12 +1136,15 @@
> except errors.PathNotChild:
> return path
>
> - if tree_locked and sys.platform == 'win32':
> - # We expect this to fail because of locking errors. (A write-locked
> - # file cannot be read-locked in the same process).
> + if tree_locked:
> + # We expect this to fail because of locking errors.
> + # (A write-locked file cannot be read-locked
> + # in the different process -- either on win32 or on linux).
> # This should be removed when the locking errors are fixed.
> - self.run_bzr_error([], 'info ' + command_string)
> - return
> + self.expectFailure('OS locks are exclusive '
> + 'for different processes (Bug #158596)',
> + self.run_bzr_subprocess,
> + 'info ' + command_string)
> out, err = self.run_bzr('info %s' % command_string)
> description = {
> (True, True): 'Lightweight checkout',

+1, go ahead and merge

--
Martin