Bazaar

  1. Bug #1674195
  2. Comment #6

Comment 6 for bug 1674195

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 1674195] Re: Buggy localtime() on Windows and 32-bit platforms

On Sat, Dec 02, 2017 at 04:46:26PM -0000, Florent Gallaire wrote:
> > If 'local' doesn't work for some reason, we should tell the user and
> suggest they use "--timezone original" rather than silently ignoring
> their (explicit) preference.
>
> In theory, but not practically. Do you really want an error message for
> 1 commit /1000 of your history and be forced to switch to 'original' for
> the 999 commits that you can show as 'local' without problem ?
>
> > I don't follow why this causes out of range errors. What is the value
> of the t variable when you hit this issue?
>
> http://bazaar.launchpad.net/~bzr-
> pqm/bzr/bzr.dev/revision/6622#bzrlib/tests/blackbox/test_commit.py
 I'm not sure I understand what this is actually trying to fix; I've
followed up to https://bugs.launchpad.net/bzr/+bug/1670243

Jelmer

--
Jelmer Vernooij <email address hidden>
PGP Key: https://www.jelmer.uk/D729A457.asc