> If 'local' doesn't work for some reason, we should tell the user and suggest they use "--timezone original" rather than silently ignoring their (explicit) preference.
In theory, but not practically. Do you really want an error message for 1 commit /1000 of your history and be forced to switch to 'original' for the 999 commits that you can show as 'local' without problem ?
> I don't follow why this causes out of range errors. What is the value of the t variable when you hit this issue?
> If 'local' doesn't work for some reason, we should tell the user and suggest they use "--timezone original" rather than silently ignoring their (explicit) preference.
In theory, but not practically. Do you really want an error message for 1 commit /1000 of your history and be forced to switch to 'original' for the 999 commits that you can show as 'local' without problem ?
> I don't follow why this causes out of range errors. What is the value of the t variable when you hit this issue?
http:// bazaar. launchpad. net/~bzr- pqm/bzr/ bzr.dev/ revision/ 6622#bzrlib/ tests/blackbox/ test_commit. py