Bazaar

  1. Bug #153493
  2. Comment #8

Comment 8 for bug 153493

Revision history for this message
John A Meinel (jameinel) wrote : Re: [Bug 153493] Re: status gives false positives for text files with CRLF (@win32)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> I'm not sure is this bug should be marked as High or Critical. For me
> it's critical enough and for 0.92 it should be fixed.
>

I think it is a Critical regression.

The reason 'diff' is blowing up is because 'internal_diff' dies when you feed
it 2 texts which have no differences. Which should also be considered a bug.

It doesn't effect any actual committed changes, etc.

Oh, and we've already handled the O_BINARY issues in the Transport code. You
can use 'osutils.O_BINARY' which is set up to handle when os.O_BINARY is not
available.

I'll write up a patch.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD4DBQFHHMOSJdeBCYSNAAMRAjXXAJdZPngKfOZwuDlrDVdmkiahW/++AJ4xC4n7
rO670Fi5LL3CvEqV0YK95Q==
=16ci
-----END PGP SIGNATURE-----