Robert Collins wrote:
>> It is possible, but not using the symlink.
>
> ??? Its certainly not possible from the command line in the example I
> have.
I am saying that in your example, "bzr log ../subproject/subtree"
instead of "bzr log link" would work.
> I don't think your example is correct.
> If tree_a/link points at tree_b, then and only then does the confusion I
> am talking about occur.
Agreed. See my subsequent email.
But it's worth noting that "bzr commit tree_b" has unclear semantics.
Does it refer to the tree root or to the branch? Because if it refers
to the tree root, then it's hard to see why bzr "bzr commit link" should
commit "tree_b/." when "bzr commit link-to-file" does not commit
"tree_b/file".
> Thats true. However, this current behaviour is a regression AFAICT - I
> believe that BzrDir.open() used to follow symlinks (but
> BzrDir.open_containing never did, and should not start following them).
I don't believe this is a regression. AFAIK, the behavior of
BzrDir.open has not changed recently.
If BzrDir.open had followed symlinks, then BzrDir.open_containing would
necessarily have followed some symlinks, since it is implemented on top
of BzrDir.open.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Robert Collins wrote:
>> It is possible, but not using the symlink.
>
> ??? Its certainly not possible from the command line in the example I
> have.
I am saying that in your example, "bzr log ../subproject/ subtree"
instead of "bzr log link" would work.
> I don't think your example is correct.
> If tree_a/link points at tree_b, then and only then does the confusion I
> am talking about occur.
Agreed. See my subsequent email.
But it's worth noting that "bzr commit tree_b" has unclear semantics.
Does it refer to the tree root or to the branch? Because if it refers
to the tree root, then it's hard to see why bzr "bzr commit link" should
commit "tree_b/." when "bzr commit link-to-file" does not commit
"tree_b/file".
> Thats true. However, this current behaviour is a regression AFAICT - I open_containing never did, and should not start following them).
> believe that BzrDir.open() used to follow symlinks (but
> BzrDir.
I don't believe this is a regression. AFAIK, the behavior of
BzrDir.open has not changed recently.
If BzrDir.open had followed symlinks, then BzrDir. open_containing would
necessarily have followed some symlinks, since it is implemented on top
of BzrDir.open.
Aaron enigmail. mozdev. org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iD8DBQFGklkK0F+ nu1YWqI0RApYoAJ 41dFQH2U8m20PUx ZBbTeugOVL15QCe LfUZ SL0paedY=
qiszttUPuVLPixY
=tOQc
-----END PGP SIGNATURE-----