Comment 4 for bug 77453
Revision history for this message
| Martin Pool (mbp) wrote Re: [Bug 77453] Re: Generates file ids that are too long | #4 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
On 13 Jan 2007, Jelmer Vernooij <email address hidden> wrote:
> status confirmed
> affects /bzr
>
> Bazaar needs to have a consistent policy as to what length file ids are
> allowed or should at least throw a decent exception if a file id is
> being added that is too long to be stored by the current revision store.
I agree.
> What characters are being escaped, how and what the maximum length of a
> file id therefore is is not something upper layers should have knowledge
> of.
>
> Robert hacked up a repository some time ago that allowed infinite (well,
> somewhat) revision ids by using the checksum of a file id as filename.
> Maybe this could be incorporated into the main tree sometime?
At minimum, the next format should not allow errors to result from
passing in overly-long or otherwise hostile ids. I'm ok with doing a
change that does only that, but it is not a priority for me at the
moment -- I would rather format changes also work on efficiency.
--
Martin