Comment 7 for bug 496721

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 496721] Re: space in url causes failure

Thanks! I'd prefer a branch.

Cheers,

Jelmer

On Fri, 2009-12-25 at 22:36 +0000, Billie Cleek wrote:
> You are right. Sorry about that. I am pretty sure that was the only way I
> could get it to work correctly. I will strip out the utf-8 encoding, add a
> unit test and resubmit. Do you prefer a patch or a pushed branch?
>
> Billie
>
> sent from my droid
>
> On Dec 25, 2009 8:15 AM, "Jelmer Vernooij" <email address hidden> wrote:
>
> - ret = subvertpy.ra.RemoteAccess(url, auth=auth,
> + ret = subvertpy.ra.RemoteAccess(urllib.quote(url.encode('utf8'),
> '/:'), auth=auth,
>
> You added an additional .encode('utf8') there.
>
> If you could add a unit test that made sure that URLs with spaces in
> them worked, that would be great. Such a test would probably belong in
> tests/test_transport.py.
>
> -- space in url causes failure https://bugs.launchpad.net/bugs/496721
>
> You received this bug notification because you are a direct subscriber of
> the bug. Status in Subver...
>