Comment 4 for bug 263570

Revision history for this message
Alexey Borzenkov (snaury) wrote :

Yes, but I have no clue how to fix this properly. :(

The problem is that there are two distributions of Subversion for Windows. Binaries built against Apache 2.0 (with libraries libapr, libapriconv and libaprutil) and binaries built against Apache 2.2 (with libraries libapr-1, libapriconv-1 and libaprutil-1). So my patch was working for Apache 2.0 binaries (which I installed by accident, distribution filenames don't even reflect if binaries are apache 2.0 or 2.2) and then at work (where I had Apache 2.2 binaries) my patch did more harm than good, first not linking to apr at all, and then later failing to copy dlls in install_lib_with_dlls.

This turns out rather complicated. Ideal solution would be sort of autodetect if we are linking against Subversion 1.4/1.5 and Apache 2.0/2.2, but I'm not entirely sure what would be an ideal way to do that. Looking thru header files it doesn't seem we can grep for exact information either. :(

Would you accept a patch that does a fuzzy testing, based on absence of libsvn_ra_dav-1.dll and and presence of -1 in libapr*.dll in ${SVN_DEV}/bin? It's not ideal, but it might work...