Comment 8 for bug 279103
Revision history for this message
| Aaron Bentley (abentley) wrote Re: [Bug 279103] Re: need to specify my LP username in the branch URL in order to pqm-submit a branch hosted on Launchpad | #8 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Martin Pool wrote:
> I think there are separate issues here:
>
> 1- what should be specified as the public_location of a branch that's
> not available to the general public? I think it's reasonable to give an
> ssh url (or an lp: url that resolves to one), but you typically should
> not include a username unless you intend everyone to log in as that
> user.
Fully agreed. A public branch location should be usable by all who have
access to that branch.
> 2- lp: urls should use the configured Launchpad username - presumably
> they're not specifying one, and it's just turning into
> bzr+ssh:
> bug 279037.
I would prefer not to make lp URLs special. It seems like the wrong layer.
For users with differing launchpad and local usernames, a bzr+ssh URL as
you specified in 1. will not work, because Bazaar will use their local
username. Users can typically configure SSH, but not all users can, and
most would expect launchpad-login to have that effect.
So I propose that we provide a per-host configuration mechanism that
launchpad-login can hook into.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iD8DBQFI6v6m0F+
0j0z7Cfbe+
=jAuj
-----END PGP SIGNATURE-----