Comment 1 for bug 279831

Revision history for this message
John A Meinel (jameinel) wrote : Re: C-extensions in bzr.dev cause "bzr gcommit" to issue exception

Can you give a bit more context?

For example, what does "bzr status" give? Does it give something different if you do or don't have the extensions compiled?

Can you add a debug statement right before the assertion? Something like:

print (file_id, paths, changed_content, versioned, parent_ids, names, kinds, executables, present_source, present_target)

Looking at the code in question, it would seem that it might be getting back an entry which the gtk/diff.py code considers unchanged.

Actually, never mind, I tracked it down.

The specific code in bzr-gtk is saying:
elif changed_content is True or executables[0] != executables[1]:

however, the pyrex iter_changes code returns "0" or "1" and not True or False. So "changed_content is True" is failing.

Instead, the gtk code should be doing:
elif changed_content or executables[0] != executables[1]: