@Martin, more interesting thing that actually internal launchpad plugin has raised SocketConnectionError, while the code in explorer expects to get NotLaunchpadBranch only. See explorer/lib/hosted_url_resolver.py:
def get_branch_url(self, location='.'):
"""Get the web branch URL for a given location.
@return: the URL as a string or None if none.
"""
# TODO: generalise this to support sites other than Launchpad, e.g.
# Savannah and/or Loggerhead on an Intranet server.
try:
# Note: this only checks the public location and the push location.
# I think it ought to check the bound and parent locations as well.
# See https://bugs.launchpad.net/bzr/+bug/488057.
return self._lp_open_cmd._get_web_url(self._lp_service, location)
except NotLaunchpadBranch:
return None
So, should we catch socket errors here? Or should launchpad plugin be improved in that area?
@Martin, more interesting thing that actually internal launchpad plugin has raised SocketConnectio nError, while the code in explorer expects to get NotLaunchpadBranch only. See explorer/ lib/hosted_ url_resolver. py:
def get_branch_ url(self, location='.'):
"""Get the web branch URL for a given location.
@return: the URL as a string or None if none. /bugs.launchpad .net/bzr/ +bug/488057. open_cmd. _get_web_ url(self. _lp_service, location)
"""
# TODO: generalise this to support sites other than Launchpad, e.g.
# Savannah and/or Loggerhead on an Intranet server.
try:
# Note: this only checks the public location and the push location.
# I think it ought to check the bound and parent locations as well.
# See https:/
return self._lp_
except NotLaunchpadBranch:
return None
So, should we catch socket errors here? Or should launchpad plugin be improved in that area?