crash/freeze when opening ftp 'virtual repository'

[Steve Melnikoff]

Explorer crashed when trying to open a 'virtual repository' via FTP access to a directory

[Martin Pool (mbp)]

Thanks for the report. We're going to need more information, eg a bzr crash file or a python traceback, to be able to do anything with this. If you have one, please attach it to this bug and put it back to 'new'.

[André Bachmann (andrebachmann-dd)]

Perhaps I have reproduced this problem. I started a FTP server (Filezilla) and set a directory with many Bazaar repositories in it as the starting directory for an anonymous user. If I now open "ftp://anonymous@localhost" with my browser, I am able to see these Bazaar repositories. But if I try "bzr explorer ftp://anonymous@localhost", I get this:

bzr: ERROR: Generic path error: '': error with list_dir: 550 Directory not found)

The same error happens if I try only "bzr explorer ftp://localhost". This is in my .bzr.log:

========================================================
1.121 Traceback (most recent call last):
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\explorer\lib\explorer.py", line 1484, in callable_with_cleanup
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\explorer\lib\explorer.py", line 1649, in _open_location_task
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\explorer\lib\explorer.py", line 1663, in _show_unable_to_open_location
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\explorer\lib\explorer.py", line 1687, in open_virtual_repo
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\explorer\lib\location_viewer.py", line 163, in add_location
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\explorer\lib\location.py", line 178, in view
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\explorer\lib\view_repository.py", line 291, in ui
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\explorer\lib\view_repository.py", line 295, in refresh_view
  File "C:/Users/abachmann/AppData/Roaming/bazaar/2.0/plugins\explorer\lib\view_repository.py", line 325, in _collect_data
  File "bzrlib\bzrdir.pyo", line 315, in find_bzrdirs
  File "bzrlib\bzrdir.pyo", line 298, in list_current
  File "bzrlib\transport\ftp\__init__.pyo", line 569, in list_dir
  File "bzrlib\transport\ftp\__init__.pyo", line 220, in _translate_ftp_error
FtpPathError: Generic path error: '': error with list_dir: 550 Directory not found)
========================================================

If I look in Filezilla's log, there is something weird going on, because there is no directory "-müller" within. I tried first without a password, then with one, therefor these two connect attempts:

(000007)11.07.2011 11:08:38 - (not logged in) (::1)> Connected, sending welcome message...
(000007)11.07.2011 11:08:38 - (not logged in) (::1)> 220-FileZilla Server version 0.9.39 beta
(000007)11.07.2011 11:08:38 - (not logged in) (::1)> 220-written by Tim Kosse (<email address hidden>)
(000007)11.07.2011 11:08:38 - (not logged in) (::1)> 220 Please visit http://sourceforge.net/projects/filezilla/
(000007)11.07.2011 11:08:40 - (not logged in) (::1)> USER abachmann
(000007)11.07.2011 11:08:40 - (not logged in) (::1)> 331 Password required for abachmann
(000007)11.07.2011 11:08:40 - (not logged in) (::1)> PASS
(000007)11.07.2011 11:08:40 - abachmann (::1)> 230 Logged on
(000007)11.07.2011 11:08:40 - abachmann (::1)> TYPE I
(000007)11.07.2011 11:08:40 - abachmann (::1)> 200 Type set to I
(000007)11.07.2011 11:08:40 - abachmann (::1)> TYPE I
(000007)11.07.2011 11:08:40 - abachmann (::1)>...

[Jonathan Riddell (jr)]

bzr explorer freezes for me when I open an ftp "virtual repository", either way not what it should be doing.

[André Bachmann (andrebachmann-dd)]

I just retested opening a virtual repository via ftp. Bazaar 2.4.2-1 with qbzr trunk and bzr-explorer trunk on Win7 x64 were used.
Bzr Explorer doesn't freeze, but I get an ugly error:

...
FtpPathError: Generic path error: '': error with list_dir: 550 Directory not found)
...

This is the content of my ftp server:

C:\Users\bachmann>ftp
ftp> open localhost
Verbindung mit talentix.mp.local wurde hergestellt.
220-FileZilla Server version 0.9.40 beta
220-written by Tim Kosse (<email address hidden>)
220 Please visit http://sourceforge.net/projects/filezilla/
Benutzer (talentix.mp.local:(none)): anonymous
331 Password required for anonymous
Kennwort:
230 Logged on
ftp> ls
200 Port command successful
150 Opening data channel for directory list.
Bazaar-20120109.7z
bzr
bzr-explorer
bzrtools
qbzr
qbzr.zip
226 Transfer OK
FTP: 65 Bytes empfangen in 0,00Sekunden 65000,00KB/s
ftp>