Comment 12 for bug 429911

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: SV: [Bug 429911] Re: BZR > Explorer > UnicodeDecodeError

poulanker пишет:
> I have no python skills, but your instructions were good and easy to
> carry out :-)
>
> This is the result of the print statement when I have entered just "notepad.exe" in the editor field:
> 'command is notepad.exe'
> If I leave the editor field empty, you apparently try to resolve the path to wordpad.exe:
> 'command is C:/Programmer/Windows NT/Tilbeh°r/WORDPAD.EXE'
>
> On my danish Windows XP this path contains a danish character (Accessories translates to Tilbehør in danish).
> May I suggest that you do not try to resolve the path, but only default to the name of the editor. I also think that "notepad.exe" is a better choice, because I figure that the editor is only used for short messages like changes description, version info and the like.
>
> I hope this helps.

Wow. Cool. Nice catch. On my Russian Windows XP the path does not
contain non-ascii characters.

Ian, it seems we should cast editor to unicode. There is helper function
in bzrlib/win32utils.py.