bzr email commit hook

  1. Bug #250901
  2. Comment #3

Comment 3 for bug 250901

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 250901] Re: traceback caused by difflimit = 0

On Tue, 2008-07-22 at 18:35 +0000, James Westby wrote:
> If difflimit == 0 then it returns None, rather than the "diff too large"
> string returned if the value is > 0 and the diff is larger than that. Either
> a string should be returned, or the None value should be handled.
>
> However, Steve said that he thought 0 would mean no-limit. I think
> either that, or using -1 to mean this would be a good idea.

This is a regression - the docs say use 0 to disable the feature.

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.