Comment 5 for bug 275912

Revision history for this message
Forage (forage) wrote :

That will make it mighty complex I think.

I never expected the options of Eclipse to be workspace dependant. Does this go for basically all options in the prefs? If not, how is the distinction made? We might be able to use that.

Specifying something to be relative or absolute isn't really required as far as I can tell. The plugin can determine that instead. At least on Windows, if there isn't a '[drive letter]:\' prefix, we are dealing with a relative path. This can start with '\', '..' or '[folder name]\'. If the plugin deems the path to be relative, enable the suggested radio buttons. If its absolute, disable them. This will prevent wrong use a bit more if people don't have a clue what the difference is (relative vs. absolute).

From the above perspective:
Letting the browse button take you to the location, relative or absolute, can be handy indeed. I wouldn't, however, go as far as allowing you to actually specify a relative path this way. If the browse button is used to specify a location, set it as a absolute location, independent of starting from relative or absolute. This, again, will prevent people from getting confused, not knowing how to get back to an absolute path.

You might argue that doing it this way, only being able to specify a relative path manually, kind of hides the feature. I think it shouldn't be too prominent in the first place. Don't forget that this is more of a power user feature (if there are non-power users using Eclipse in the first place ;-) ). Most users won't make use of it, so not everyone should be bothered with the options they'll never use.
Making it deal with all weird situations (all on USB, half on USB, etc.) won't be possible. Sooner or later it might not be able to find the bzr executable. People working portable know this can happen if they don't keep things simple. It should be up to them to deal with it, the plugin can't, no matter how many options you'll provide.