Comment 1 for bug 491368

Revision history for this message
James Westby (james-w) wrote :

I thought there was another bug for this.

The output of called tools should only be hidden if -q is used.

The steps to fix this would be:

  * bzrlib.trace.is_quiet() returns True if we should be quiet.
  * _run_command in __init__.py should be changed so that if bzrlib.trace.is_quiet()
    returns False we run

    trace.note(msg)
    proc = subprocess.Popen(command, cwd=basedir,
            stdout=subprocess.PIPE, stderr=subprocess.STDOUT,
            stdin=subprocess.PIPE)
    proc.communicate()
    if proc.retcode != 0:
        raise errors.BzrCommandError(error_msg)

Thanks,

James