"configure" should not change files which are under VCS control
Bug #861291 reported by
Daniel Hahler
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
byobu |
Fix Released
|
Wishlist
|
Dustin Kirkland | ||
byobu (Ubuntu) |
Fix Released
|
Wishlist
|
Dustin Kirkland |
Bug Description
When you run "configure" with a custom prefix, all the "bin" files get changed as follows:
-[ -z "${BYOBU_PREFIX}" ] && export BYOBU_PREFIX="/usr" || export BYOBU_PREFIX
+[ -z "${BYOBU_PREFIX}" ] && export BYOBU_PREFIX=
A workaround for this might be to set BYOBU_PREFIX from the path of the binary itself dynamically, like with:
readlink -f "$0"
or the more portable (?)
$( cd -P -- "$(dirname -- "$(command -v -- "$0")")" && pwd -P )
Apart from that, a separate directory might be used to "make" (and mangle) the files therein for "make install".
Changed in byobu: | |
status: | Incomplete → Fix Committed |
Changed in byobu (Ubuntu): | |
status: | New → Fix Committed |
importance: | Undecided → Wishlist |
Changed in byobu: | |
assignee: | nobody → Dustin Kirkland (kirkland) |
Changed in byobu (Ubuntu): | |
assignee: | nobody → Dustin Kirkland (kirkland) |
Changed in byobu: | |
status: | Fix Released → Triaged |
Changed in byobu (Ubuntu): | |
status: | Fix Released → Triaged |
Changed in byobu: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hmm, that's a lot of shell forks. I've been trying to remove shell forks from byobu, and this would introduce a lot more.