_is_opt_registered does identity check

[Joshua Harlow]

When using _is_opt_registered (of cfg) it seems like there is a identity check that happens here instead of an equality check.

In glance, it was suggested to define the options inside a function, and then register the opt when that function is entered, this of course makes the opt registration blow up, since the option will not be "identically" the same (due to a previous function call occurring with a different opt, that is equivalent but not identical).

This also will happen if opts are defined inside classes (ie anywhere not globally) and that class is constructed twice or a function that defines them is called twice (thus causing duplication option errors).

Possible this line:

if opts[opt.dest]['opt'] is not opt:

Should use equality (or check on the names??)

[Mark McLoughlin (markmc)]

This was intentional to avoid registering different option schemas under the same name

Use cases are:

  opt = StrOpt('foo')

  def do_something():
      CONF.register_opt(opt)
      print CONF.foo

or

  class Bar:

      opt = StrOpt('foo')

      def __init__(self):
          CONF.register_opt(opt)

      def do_something(self):
          print CONF.foo

However, I'd take a patch to add an equality check, but all fields need to be checked, not just the name

[Joshua Harlow (harlowja)]

Will do, let me work on that.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/10081

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/10081
Committed: http://github.com/openstack/openstack-common/commit/90da88cce51bccd320e89141ed7384d2e7ccca9d
Submitter: Jenkins
Branch: master

commit 90da88cce51bccd320e89141ed7384d2e7ccca9d
Author: Giampaolo Lauria <email address hidden>
Date: Fri Jul 20 16:41:45 2012 -0400

    Modifies _is_opt_registered fcn to check for duplicate opts

    This change fixes bug 999307

    Currently, the check for duplicate options is done by checking
    whether they are the same object. The proposed fix is to check whether
    all the object fields have the same value.

    Change-Id: I2b72d630a0c8821df1d81e25d316d8d9195be492