libvirt get_disks() raises an error

[Julien Danjou]

This method is not used anywhere, but trying to use it raises an error. I'll need it so I'm opening this bug to be able to fix it.

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/eventlet/hubs/poll.py", line 97, in wait
    readers.get(fileno, noop).cb(fileno)
  File "/usr/lib/python2.7/dist-packages/eventlet/greenthread.py", line 192, in main
    result = function(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/nova/service.py", line 101, in run_server
    server.start()
  File "/usr/lib/python2.7/dist-packages/nova/service.py", line 162, in start
    self.manager.init_host()
  File "/root/ceilometer/ceilometer/nova/manager.py", line 46, in init_host
    self._fetch_diskio(nova.context.get_admin_context())
  File "/root/ceilometer/ceilometer/nova/manager.py", line 58, in _fetch_diskio
    for disk in conn.get_disks(instance.name):
  File "/usr/lib/python2.7/dist-packages/nova/virt/libvirt/connection.py", line 1606, in get_disks
    for child in node.children:
AttributeError: 'Element' object has no attribute 'children'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/7347

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/7347
Committed: http://github.com/openstack/nova/commit/a345ee5aff9332560c331947a228e19620033321
Submitter: Jenkins
Branch: master

commit a345ee5aff9332560c331947a228e19620033321
Author: Julien Danjou <email address hidden>
Date: Fri May 11 17:31:38 2012 +0200

    Fix libvirt Connection.get_disks method

    The get_disks() method is not used anywhere yet, and is not tested properly,
    but it does not work as reported in bug #998089.

    This patch add unit test for it and fixes it so it's now possible to
    retrieve the list of device name associated with a libvirt domain.

    Change-Id: If09fb683364174fe02cbcbec4c6bbcda991287d6
    Signed-off-by: Julien Danjou <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/essex
Review: https://review.openstack.org/7380