XenAPI rescue sometimes rescues swap

Bug #997835 reported by Brian Lamar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Brian Lamar

Bug Description

Every so often when rescuing an instance, the swap partition will be rescued. This seems to be due to a bug in vmops.py which assumes the rootfs VBD is going to be the second one returned if there are multiple disks (swap most likely is the first). This doesn't seem to be always true so it would make more sense to check for userdevice = "0".

Brian Lamar (blamar)
Changed in nova:
assignee: nobody → Brian Lamar (blamar)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/7328

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/7328
Committed: http://github.com/openstack/nova/commit/1d7b4f1e5eb3d6e00eeaa927c67c765f726b9d77
Submitter: Jenkins
Branch: master

commit 1d7b4f1e5eb3d6e00eeaa927c67c765f726b9d77
Author: Brian Lamar <email address hidden>
Date: Thu May 10 16:54:12 2012 -0400

    More accurate rescue mode testing for XenAPI

    Update test_rescue to make sure the swap partition wasn't rescued. Since
    this test fails with the current code, I also updated the code so the test
    passed.

    Fixes bug 997835

    Change-Id: I9f09b3bbbee0ddfcbfdb243a7dff0b9bae99925d

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.