instance_usage_audit fail because using admin context to talk to glance

[Chris Behrens]

https://review.openstack.org/#/c/7309
commit 53adfd289bf7226f1c6f59c17608e42f3083f130

Added pulling of image metadata when sending usage notifications. However, instance_usage_audit only has an admin context... so it'll fail.

We should probably keep track of the image metadata along with the instance, if we need to use it for notifications. The new system_metadata table would be perfect for this!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/7332

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/7332
Committed: http://github.com/openstack/nova/commit/7d390243c4edc8991d0590273ef48e7d793e6113
Submitter: Jenkins
Branch: master

commit 7d390243c4edc8991d0590273ef48e7d793e6113
Author: Chris Behrens <email address hidden>
Date: Fri May 11 00:10:00 2012 +0000

    Store image properties with instance system_metadata

    In implementing adding 'image_meta' to instance notifications,
    this was committed:

    https://review.openstack.org/#/c/7309
    commit 53adfd289bf7226f1c6f59c17608e42f3083f130

    However, it's buggy because an instance could have been deleted after we
    built from it... and bin/instance-usage-audit uses an admin context with
    which we cannot query glance.

    This stores image properties with instances in nova as system_metadata
    and notifications will use that data.

    Fixes bug 997833

    Change-Id: I50575969b5cb28adaae9a713e749dc486772c417