Role name is not required

[Chris Fattarsi]

The keystone client requires a name when creating a role, but curling with an empty name field will create a role. The client and the back end should be consistent.

curl -i -X POST -d '{"role":{"name": ""}}' -H 'x-auth-token: this-is-my-token' -H 'Content-type: application/json' http://localhost:35357/v2.0/OS-KSADM/roles

HTTP/1.1 200 OK
Content-Type: application/json
Vary: X-Auth-Token
Content-Length: 64
Date: Thu, 10 May 2012 17:35:58 GMT

{"role": {"name": "", "id": "a7873cd5ca6e4a799ddb8aedcb3d4881"}}

[Mohammed Naser (mnaser)]

I would like to fix this however can anyone comment from core team on how to perform validation?

It seems that you can create empty usernames, role names and tenants too (can't find any validation).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/7464

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/7464
Committed: http://github.com/openstack/keystone/commit/19b6076869f6e177febc559b191f4ef9c352e55b
Submitter: Jenkins
Branch: master

commit 19b6076869f6e177febc559b191f4ef9c352e55b
Author: Mohammed Naser <email address hidden>
Date: Tue May 15 17:43:50 2012 -0400

    Add validations of 'name' field for roles, users and tenants.

    Fixes LP Bug #997725

    Change-Id: I2759d21bed3c0e42642de96184844e1b9e795bb6