Changing visual gain in preferences does not affect "Filtered" display type

Bug #997435 reported by x
8
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
Thomas Vincent

Bug Description

While using the filtered or simple GL display type, changing the visual gain settings does not change the waveform at all. The settings work as normal when using filtered GL display type.

These settings are the most useful while using the filtered display type which with normal settings doesn't provide enough detail.

Note - Filtered GLSL was not mentioned because the waveform isn't visible when it's selected, this is a different bug all together.

My system - Arch Linux 64 bit, Gnome Shell 3.4

Related branches

Revision history for this message
Thomas Vincent (vrince) wrote :

Yeah I know I was lazy ... I need to make it work in all waveforms. I am on it ...
Some are already fixed in the waveform-2.0_pure-gl branch, I'll do it in this branch and it should be merged soon.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Thomas Vincent (vrince)
milestone: none → 1.11.0
status: Confirmed → In Progress
Revision history for this message
x (broma0-deactivatedaccount) wrote : Re: [Bug 997435] Re: Changing visual gain in preferences does not affect "Filtered" display type

That would be awesome. That's the only think keeping me from using trunk
On May 10, 2012 1:40 PM, "Thomas Vincent" <email address hidden> wrote:

> Yeah I know I was lazy ... I need to make it work in all waveforms. I am
> on it ...
> Some are already fixed in the waveform-2.0_pure-gl branch, I'll do it in
> this branch and it should be merged soon.
>
> ** Changed in: mixxx
> Status: New => Confirmed
>
> ** Changed in: mixxx
> Importance: Undecided => Medium
>
> ** Changed in: mixxx
> Assignee: (unassigned) => Thomas Vincent (vrince)
>
> ** Changed in: mixxx
> Milestone: None => 1.11.0
>
> ** Changed in: mixxx
> Status: Confirmed => In Progress
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/997435
>
> Title:
> Changing visual gain in preferences does not affect "Filtered" display
> type
>
> Status in Mixxx:
> In Progress
>
> Bug description:
> While using the filtered or simple GL display type, changing the
> visual gain settings does not change the waveform at all. The settings
> work as normal when using filtered GL display type.
>
> These settings are the most useful while using the filtered display
> type which with normal settings doesn't provide enough detail.
>
> Note - Filtered GLSL was not mentioned because the waveform isn't
> visible when it's selected, this is a different bug all together.
>
> My system - Arch Linux 64 bit, Gnome Shell 3.4
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/997435/+subscriptions
>

Thomas Vincent (vrince)
Changed in mixxx:
status: In Progress → Fix Committed
Thomas Vincent (vrince)
Changed in mixxx:
status: Fix Committed → In Progress
Revision history for this message
x (broma0-deactivatedaccount) wrote :

What's the status on this one? I think this might also fix this bug as well
- https://bugs.launchpad.net/bugs/976650

On Sat, May 12, 2012 at 7:34 PM, Thomas Vincent
<email address hidden>wrote:

> ** Changed in: mixxx
> Status: Fix Committed => In Progress
>
> ** Branch linked: lp:~vrince/mixxx/waveform-2.0_pure-gl
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/997435
>
> Title:
> Changing visual gain in preferences does not affect "Filtered" display
> type
>
> Status in Mixxx:
> In Progress
>
> Bug description:
> While using the filtered or simple GL display type, changing the
> visual gain settings does not change the waveform at all. The settings
> work as normal when using filtered GL display type.
>
> These settings are the most useful while using the filtered display
> type which with normal settings doesn't provide enough detail.
>
> Note - Filtered GLSL was not mentioned because the waveform isn't
> visible when it's selected, this is a different bug all together.
>
> My system - Arch Linux 64 bit, Gnome Shell 3.4
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/997435/+subscriptions
>

--
Matt Brooks

Revision history for this message
Thomas Vincent (vrince) wrote :

This bug is fix in pure-gl branch, should be merge pretty soon.
#976650 is another issue related to how waveform data is computed.

Thomas Vincent (vrince)
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6422

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.