http client throws error with no content-type header in http response
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Zorba |
Fix Released
|
Medium
|
Paul J. Lucas |
Bug Description
in modules/
the surprising part is that in the following code transcode:
if ( transcode:
lStream.reset(
new transcode:
theCurren
)
);
}
in the constructor of the icu_streambuf (src/util/
external_conv_( no_conv_ ? nullptr : create_conv( charset ) )
the correct behavior would be if the http-client would not throw an error if the content-type header is missing.
Related branches
- Dennis Knochenwefel: Approve
- Paul J. Lucas: Approve
-
Diff: 312 lines (+84/-40)8 files modifiedmodules/com/zorba-xquery/www/modules/http-client.xq.src/error_thrower.h (+9/-9)
modules/com/zorba-xquery/www/modules/http-client.xq.src/http_response_parser.cpp (+34/-19)
src/diagnostics/diagnostic_en.xml (+1/-1)
src/diagnostics/pregenerated/dict_en.cpp (+1/-1)
src/util/icu_streambuf.cpp (+4/-1)
src/util/icu_streambuf.h (+3/-0)
src/util/passthru_streambuf.cpp (+5/-0)
src/util/passthru_streambuf.h (+27/-9)
Changed in zorba: | |
status: | New → In Progress |
Changed in zorba: | |
status: | In Progress → Opinion |
Changed in zorba: | |
status: | Opinion → Fix Committed |
milestone: | none → 2.5 |
Changed in zorba: | |
status: | Fix Committed → Fix Released |
Are you also saying that the correct behavior would also be to not do transcoding and just hope that the unspecified character set is UTF-8?