"carbon" as internal stats metric prefix conflicts with hosts named carbon in common scenario

Bug #994314 reported by Jeff Blaine
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
carbon
Fix Released
Low
Jeff Blaine

Bug Description

If I have a host named "carbon", I can't use "carbon" as a prefix for that host's metrics because it is already taken by the internal carbon stats.

Revision history for this message
Jeff Blaine (jblaine-kickflop) wrote :

I'll take on this challenge.

Changed in graphite:
assignee: nobody → Jeff Blaine (jblaine-kickflop)
Revision history for this message
Nicholas Leskiw (nleskiw) wrote : Re: [Bug 994314] Re: "carbon" as internal stats metric prefix conflicts with hosts named carbon in common scenario

You will probably want to start in carbon/lib/carbon/instrumentation.py
-Nick

Jeff Blaine <email address hidden> wrote:

>I'll take on this challenge.
>
>** Changed in: graphite
> Assignee: (unassigned) => Jeff Blaine (jblaine-kickflop)
>
>--
>You received this bug notification because you are subscribed to
>Graphite.
>https://bugs.launchpad.net/bugs/994314
>
>Title:
> "carbon" as internal stats metric prefix conflicts with hosts named
> carbon in common scenario
>
>Status in Graphite - Enterprise scalable realtime graphing:
> Confirmed
>
>Bug description:
> If I have a host named "carbon", I can't use "carbon" as a prefix for
> that host's metrics because it is already taken by the internal carbon
> stats.
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/graphite/+bug/994314/+subscriptions

Revision history for this message
Jeff Blaine (jblaine-kickflop) wrote :

Thanks Nick.

The main devs here should pick what it should be renamed.

Suggestions:

carbon-internal

_carbon

carbon_data

If I don't hear from anyone in a week or so, I'm going to just go with _carbon.

Revision history for this message
Jeff Blaine (jblaine-kickflop) wrote :

Oh, I suppose I could just make it configurable and leave the default as 'carbon'.

That's probably the right thing. Duh.

Revision history for this message
Nicholas Leskiw (nleskiw) wrote :

I agree, you can put an option in carbon.conf called 'CARBON_METRIC_PREFIX' or something similar.

Thanks for your help.

-Nick

Jeff Blaine <email address hidden> wrote:

>Oh, I suppose I could just make it configurable and leave the default as
>'carbon'.
>
>That's probably the right thing. Duh.
>
>--
>You received this bug notification because you are subscribed to
>Graphite.
>https://bugs.launchpad.net/bugs/994314
>
>Title:
> "carbon" as internal stats metric prefix conflicts with hosts named
> carbon in common scenario
>
>Status in Graphite - Enterprise scalable realtime graphing:
> Confirmed
>
>Bug description:
> If I have a host named "carbon", I can't use "carbon" as a prefix for
> that host's metrics because it is already taken by the internal carbon
> stats.
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/graphite/+bug/994314/+subscriptions

Sidnei da Silva (sidnei)
affects: graphite → carbon
Revision history for this message
Jeff Blaine (jblaine-kickflop) wrote :

This was merged in as ca51ef411d0097ae0cdca9e7ca3bc7576210c81a and is found in release 0.9.10

Changed in carbon:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.