ec2rc.sh uses internal urls instead of public

Bug #994297 reported by Sam Morrison
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Sam Morrison
Essex
Fix Released
High
Mark McLoughlin

Bug Description

The endpoints in ec2rc.sh are the default which is internal in url_for

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/7094

Changed in horizon:
assignee: nobody → Sam Morrison (sorrison)
status: New → In Progress
Devin Carlen (devcamcar)
Changed in horizon:
milestone: none → folsom-1
importance: Undecided → High
Revision history for this message
Joseph Heck (heckj) wrote :

This proposed bug solves this bug - https://review.openstack.org/#/c/7074/

-j

Revision history for this message
Sam Morrison (sorrison) wrote :

I don't think this is a duplicate.

When generating novarc and ec2rc files these go to users so should always use publicURL

For our dashboard we want it to use internalURLs by default for things so it goes via our internal network. But for users they should always be using our publicURLs

Revision history for this message
Joseph Heck (heckj) wrote : Re: [Bug 994297] Re: ec2rc.sh uses internal urls instead of public

I agree, and the patch that just merged in enables exactly that, and with also including a means of overriding that default of publicURL from a horizon settings file should you want/need to do so.

-joe

On May 3, 2012, at 5:01 PM, Sam Morrison <email address hidden> wrote:

> *** This bug is a duplicate of bug 994151 ***
> https://bugs.launchpad.net/bugs/994151
>
> I don't think this is a duplicate.
>
> When generating novarc and ec2rc files these go to users so should
> always use publicURL
>
> For our dashboard we want it to use internalURLs by default for things
> so it goes via our internal network. But for users they should always be
> using our publicURLs
>
> --
> You received this bug notification because you are a member of Nebula,
> which is a bug assignee.
> https://bugs.launchpad.net/bugs/994297
>
> Title:
> ec2rc.sh uses internal urls instead of public
>
> Status in OpenStack Dashboard (Horizon):
> In Progress
> Status in OpenStack Dashboard (Horizon) essex series:
> Triaged
>
> Bug description:
> The endpoints in ec2rc.sh are the default which is internal in url_for
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/horizon/+bug/994297/+subscriptions

Revision history for this message
Sam Morrison (sorrison) wrote :

Maybe I don't understand but I though the OPENSTACK_ENDPOINT_TYPE is the url type that horizon will use by default when talking to services?

If so I want to set this to internalURL so all horizon -> nova/keystone etc will go via our internal network but for when real users are using my cloud they should be using publicURL which is on our public network.

Also the code to generate the endpoints in for the novarc file specify publicURL explicitly so I would expect the ec2rc file to be generated the same.

Revision history for this message
Joseph Heck (heckj) wrote :

Good point Sam - I was making an assumption that a dashboard should always use the publicURL endpoints, which is implying a specific implementation that you're not using. Removing the duplicate status of this bug.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/7094
Committed: http://github.com/openstack/horizon/commit/a07df1700c81f67623816f9c710bde3d694373cf
Submitter: Jenkins
Branch: master

commit a07df1700c81f67623816f9c710bde3d694373cf
Author: Sam Morrison <email address hidden>
Date: Fri May 4 09:12:47 2012 +1000

    Use publicURLs for generated endpoints for ec2rc.sh

    Fixes bug 994297

    Change-Id: Icbc0b3ca327d87754bac291b0d179faacdabc7aa

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/essex)

Fix proposed to branch: stable/essex
Review: https://review.openstack.org/7723

Revision history for this message
Devin Carlen (devcamcar) wrote :

Review for stable/essex: https://review.openstack.org/7723

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/essex)

Reviewed: https://review.openstack.org/7723
Committed: http://github.com/openstack/horizon/commit/83647436f7cb0ab1fae1ff0054b0f7d5231725a5
Submitter: Jenkins
Branch: stable/essex

commit 83647436f7cb0ab1fae1ff0054b0f7d5231725a5
Author: Sam Morrison <email address hidden>
Date: Fri May 4 09:12:47 2012 +1000

    Use publicURLs for generated endpoints for ec2rc.sh

    Fixes bug 994297

    Change-Id: Icbc0b3ca327d87754bac291b0d179faacdabc7aa

Thierry Carrez (ttx)
Changed in horizon:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.