lxc-clone can expand wildcards in the configuration file

Bug #993515 reported by Serge Hallyn
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
lxc (Ubuntu)
Fix Released
High
Unassigned
Precise
Fix Released
High
Unassigned

Bug Description

=====================
SRU justification:
1. impact: configuration files for cloned containers can be corrupted
2. development fix: put quotes around the variable being echoed whose contents are being expanded.
3. stable fix: same as development fix
4. test case:
 touch xyz:xyz
 lxc-create -t ubuntu -n p1
 lxc-clone -o p1 -n p2
 grep xyz /var/lib/lxc/p2/config
5. regression potential: none.
=====================

In particular, the '*:*' in the stock lxc.devices.cgroup.allow entry will be expanded if there is a *:* file in cwd.

Changed in lxc (Ubuntu):
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lxc - 0.8.0~rc1-4ubuntu2

---------------
lxc (0.8.0~rc1-4ubuntu2) quantal; urgency=low

  * lxc-clone: put quotes around $line to avoid expansion (LP: #993515)
 -- Serge Hallyn <email address hidden> Wed, 02 May 2012 15:23:52 -0500

Changed in lxc (Ubuntu):
status: Confirmed → Fix Released
description: updated
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Serge, this seems important enough to push back into precise in an SRU.

Changed in lxc (Ubuntu Precise):
status: New → Triaged
importance: Undecided → High
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

@Clint,

yes, I pushed the package to precise-proposed a few hours ago. Seems I forgot to hit 'affects release'.

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Just FYI on the status, 0.7.5-3ubuntu53 will progress to precise-updates tomorrow (it has only been in precise-proposed 6 days, but all bugs are verified), and then we can allow the uploaded 0.7.5-3ubuntu54 into precise-proposed.

Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Serge, or anyone else affected,

Accepted lxc into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in lxc (Ubuntu Precise):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks, Martin.

Verified the bug is fixed, and the lxc test-suite passed all its tests.

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lxc - 0.7.5-3ubuntu54

---------------
lxc (0.7.5-3ubuntu54) precise-proposed; urgency=low

  * lxc-clone: put quotes around $line to avoid expansion (LP: #993515)
 -- Serge Hallyn <email address hidden> Wed, 02 May 2012 15:28:22 -0500

Changed in lxc (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.