501 Not Implemented response missing "title" attribute

Bug #991936 reported by Dolph Mathews
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Dolph Mathews

Bug Description

501 responses from keystone are missing the error message title attribute, useful for GUI's. In addition, the HTTP status code returned by keystone appears as "501 None" instead of "501 Not Implemented".

Notice the error title attribute appears as "null" in the JSON response:

    $ curl -H 'X-Auth-Token: ADMIN' http://localhost:35357/v2.0/endpoints
    {"error": {"message": "The action you have requested has not been implemented.", "code": 501, "title": null}}

XML response appears similarly:

    $ curl -H 'X-Auth-Token: ADMIN' -H 'Accept: application/xml' http://localhost:35357/v2.0/endpoints
    <?xml version="1.0" encoding="UTF-8"?>
    <error xmlns="http://docs.openstack.org/identity/api/v2.0" message="The action you have requested has not been implemented." code="501"/>

And the headers returned by keystone appears as "HTTP/1.1 501 None":

    $ curl -H 'X-Auth-Token: ADMIN' http://localhost:35357/v2.0/endpoints -v
    [...]
    < HTTP/1.1 501 None
    < Content-Type: application/json
    < Vary: X-Auth-Token
    < Content-Length: 109
    < Date: Mon, 30 Apr 2012 12:56:47 GMT
    [...]

The client does not utilize this attribute (AFAIK), so it's not reproducible there:

    $ keystone --token=ADMIN --endpoint=http://localhost:35357/v2.0 endpoint-list
    The action you have requested has not been implemented. (HTTP 501)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/6924

Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/6924
Committed: http://github.com/openstack/keystone/commit/330d4af34f190517b3e40c9abf451dc1bc992fe3
Submitter: Jenkins
Branch: master

commit 330d4af34f190517b3e40c9abf451dc1bc992fe3
Author: Dolph Mathews <email address hidden>
Date: Mon Apr 30 08:05:28 2012 -0500

    Misnamed exception attribute (bug 991936)

    - exception.NotImplemented 'action' should have been 'title'
    - Automated test coverage of exceptions to catch this in the future

    Change-Id: I238e6bc8426ae009f570f0a04d2ea28501ae23fc

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.