gpass import code incorrectly calculates padding

[Marc Deslauriers]

When attempting to import a gpass database with padding, the following error is generated:

Traceback (most recent call last):
  File "/usr/bin/pasaffe-import-gpass", line 121, in <module>
    gpass = gpassfile.GPassFile(filename, password)
  File "/usr/lib/python2.7/dist-packages/pasaffe_lib/gpassfile.py", line 35, in __init__
    self.readfile(filename, password)
  File "/usr/lib/python2.7/dist-packages/pasaffe_lib/gpassfile.py", line 68, in readfile
    entry_type = self.get_string()
  File "/usr/lib/python2.7/dist-packages/pasaffe_lib/gpassfile.py", line 150, in get_string
    length = struct.unpack("<I", self.get_int())[0]
struct.error: unpack requires a string argument of length 4

[Launchpad Janitor (janitor)]

This bug was fixed in the package pasaffe - 0.17-0ubuntu1

---------------
pasaffe (0.17-0ubuntu1) quantal; urgency=low

  * New upstream release
   - Add command-line option to specify default database
   - Don't save database specified on command line as default
   - Properly handle entries that have no URL specified (LP: #980608)
   - Fix logging in pasaffe-import scripts so we can debug failures
     (LP: #991143)
   - Correctly strip gpass database padding (LP: #991204)
   - Properly handle unicode characters with optparse (LP: #983210)
 -- Marc Deslauriers <email address hidden> Thu, 03 May 2012 20:37:15 -0400

[Marc Deslauriers (mdeslaur)]

SRU Request:

[Impact]
gpass database import script fails on a large number of gpass databases because of incorrect handling of the padding byte

[Development Fix]
Quantal has been fixed by updating to version 0.17 that contains the fix for this issue

[Stable Fix]
See attached patch for minimal fix for this issue.

[Test Case]
This may be slightly complicated
1- on an older release, install gpass
2- create a database
3- attempt to import into pasaffe
4- repeat until a database cannot be imported, and try again with the update

[Regression Potential]
This is an obvious fix, and if it's incorrect it would not prevent Pasaffe from working

[Martin Pitt (pitti)]

Hello Marc, or anyone else affected,

Accepted pasaffe into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Marc Deslauriers (mdeslaur)]

I confirm the package in -proposed fixes the issue.

[Launchpad Janitor (janitor)]

This bug was fixed in the package pasaffe - 0.16-0ubuntu1.1

---------------
pasaffe (0.16-0ubuntu1.1) precise-proposed; urgency=low

  * debian/patches/lp980608.patch: Don't print an error if trying to open a
    URL when none is set in an entry. (LP: #980608)
  * debian/patches/lp991143.patch: add option to turn on debugging when
    using the pasaffe-import-* scripts. (LP: #991143)
  * debian/patches/lp991204.patch: properly strip gpass database padding.
    (LP: #991204)
  * debian/patches/lp983210.patch: Properly handle unicode chars with
    optparse. (LP: #983210)
 -- Marc Deslauriers <email address hidden> Thu, 03 May 2012 20:13:13 -0400