Musicbrainz lookup not working if data track present

[Eike Thaden]

The lookup of metadata based on the discid via Musicbrainz is not working on Ubuntu 12.04 (AMD64) for audio discs with data tracks.

[Eike Thaden (ethaden)]

I think that the code used to prepare the input for the libkcddb discid calculation is flawed at least for Musicbrainz lookups. The patch adds detection of data tracks which are then ignored when preparing the list of track offsets. The behavior for audio discs without data tracks remains unchanged. I currently don't know whether or not the modified discid calculation for discs with data tracks will work for freedb lookups, too. Strange: The discid calculation algorithm presented on the Musicbrainz web seite (http://musicbrainz.org/doc/Disc_ID_Calculation) did not yield any results for my test audio disc when using their proposed method for calculation of the lead out track offset. Instead, the lookup was successful if all data tracks are ignored and the track offset calculation is left unchanged (using method "cdda_track_firstsector").

[Eike Thaden (ethaden)]

Typo: The used method is called "cdda_disc_lastsector".

[Daniel Faust (hessijames)]

Thank you very much.
I never tested it with a cd containing data tracks.

The lead-out track issue is indeed strange. I could imagine that the application which submitted the data was broken. But testing that would be virtually impossible for me so I'm happy that it works now at least in your case.

[Eike Thaden (ethaden)]

Am 27.04.2012 20:19, schrieb HessiJames:
> Thank you very much.
> I never tested it with a cd containing data tracks.
>
> The lead-out track issue is indeed strange. I could imagine that the
> application which submitted the data was broken. But testing that would
> be virtually impossible for me so I'm happy that it works now at least
> in your case.
>
It seems that the patch does not work for the native Musicbrainz
lookups, but only for the lookups done via the Musicbrainz freedb
gateway (using the freedb protocol).