--verbose enables debug level logging

Bug #989269 reported by Paul Belanger
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Mark McLoughlin
Glance
Fix Released
Medium
Mark McLoughlin
Grizzly
Fix Released
Medium
Mark McLoughlin
OpenStack Compute (nova)
Fix Released
Medium
Joe Gordon
oslo-incubator
Fix Released
High
Davanum Srinivas (DIMS)
Grizzly
Fix Released
High
Davanum Srinivas (DIMS)

Bug Description

Currently setting --verbose in nova.conf will still allow DEBUG level message to be logged to python logger object. The issue is nova/log.py check for --debug OR --verbose for setting logging.DEBUG

The correct fix would be:
--debug = logging.DEBUG
--verbose = logging.INFO
<nothing> = logging.WARNING

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/6868

Changed in nova:
assignee: nobody → Paul Belanger (pabelanger)
status: New → In Progress
Revision history for this message
Thierry Carrez (ttx) wrote :

Looks like you're not working on that anymore. Please set back to InProgress and reassign to you if you're working on proposing a change for merging.

Changed in nova:
assignee: Paul Belanger (pabelanger) → nobody
status: In Progress → Confirmed
Thierry Carrez (ttx)
Changed in nova:
status: Confirmed → New
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/18110

Changed in oslo:
assignee: nobody → Davanum Srinivas (dims-v)
status: New → In Progress
Changed in oslo:
status: In Progress → Confirmed
status: Confirmed → In Progress
Changed in nova:
status: New → In Progress
assignee: nobody → Davanum Srinivas (dims-v)
Mark McLoughlin (markmc)
Changed in oslo:
importance: Undecided → High
Changed in nova:
assignee: Davanum Srinivas (DIMS) (dims-v) → nobody
Changed in oslo:
assignee: Davanum Srinivas (DIMS) (dims-v) → nobody
Changed in nova:
status: In Progress → Confirmed
Changed in oslo:
status: In Progress → Confirmed
Changed in oslo:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/18110
Committed: http://github.com/openstack/oslo-incubator/commit/751c35b1c8ff0730883a8ccdda9b77a49fff2405
Submitter: Jenkins
Branch: master

commit 751c35b1c8ff0730883a8ccdda9b77a49fff2405
Author: Davanum Srinivas <email address hidden>
Date: Thu Dec 13 22:42:33 2012 -0500

    Verbose should not enable debug level logging

    Fixes LP #989269

    Currently setting --verbose in will still allow DEBUG level
    message to be logged to python logger object. we need to check
    for --debug first (set DEBUG level), then --verbose (set INFO
    level) and if neither is set then set default to WARNING

    DocImpact

    Change-Id: Ic9e3cb5979b2d7283552ad3a461870373f45a239

Changed in oslo:
status: In Progress → Fix Committed
Mark McLoughlin (markmc)
Changed in glance:
assignee: nobody → Mark McLoughlin (markmc)
status: New → Confirmed
importance: Undecided → Medium
Changed in nova:
importance: Undecided → Medium
assignee: nobody → Mark McLoughlin (markmc)
Revision history for this message
Mark McLoughlin (markmc) wrote :
Changed in nova:
status: Confirmed → Fix Committed
assignee: Mark McLoughlin (markmc) → Joe Gordon (jogo)
Mark McLoughlin (markmc)
Changed in cinder:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Mark McLoughlin (markmc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/20148

Changed in glance:
status: Confirmed → In Progress
Changed in cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/20151

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/20148
Committed: http://github.com/openstack/glance/commit/79efac44b408dc37cb932c3f68dd231700d02d91
Submitter: Jenkins
Branch: master

commit 79efac44b408dc37cb932c3f68dd231700d02d91
Author: Mark McLoughlin <email address hidden>
Date: Mon Jan 21 14:30:53 2013 +0000

    Sync latest cfg and log from oslo-incubator

    Changes include:

      c5984ba Move logging config options into the log module
      751c35b Verbose should not enable debug level logging
      edcdd25 Improve millisecond logging
      a8973c5 Revert "Support lookup of value using "group.key""

    The most significant of these changes is defaulting to the WARNING log
    level which was discussed on openstack-dev:

      http://lists.openstack.org/pipermail/openstack-dev/2013-January/004223.html

    This is behaviour already documented in doc/source/configuring.rst at
    least.

    Fixes bug #989269

    DocImpact

    Change-Id: I8ed9107193a811f50ecfd9b34e99e933774405ab

Changed in glance:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/20151
Committed: http://github.com/openstack/cinder/commit/db319b1fc19962eb64b1724db2ef3048cae61769
Submitter: Jenkins
Branch: master

commit db319b1fc19962eb64b1724db2ef3048cae61769
Author: Mark McLoughlin <email address hidden>
Date: Mon Jan 21 16:25:38 2013 +0000

    Sync latest cfg and log from oslo-incubator

    Main cfg change is:

      c5984ba Move logging config options into the log module

    Logging changes include:

      c5984ba Move logging config options into the log module
      751c35b Verbose should not enable debug level logging
      edcdd25 Improve millisecond logging
      9e5912f Fix pep8 E125 errors.
      edf14e0 Enable millisecond logging by default
      9b81289 Allow nova and others to override some logging defaults
      90ada0e update deprecated stanza
      efba202 Adjust the logging_context_format_string.
      c8cf6f7 move nova.common.deprecated to openstack-common

    Fixes bug #989269

    Use new LOG.deprecated() in place of cinder.common.deprecated.warn().

    Also pull this cinder/context.py change from nova:

      ce098cc Add user/tenant shim to RequestContext

    to avoid issues caused by a s/user_id/user/ change in the context
    logging format.

    Change-Id: I3913ea54465658d93dc56e014dfe5d911b0541d6

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.