Monkey patch all the (eventlet) things

Bug #988099 reported by Rick Harris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
John Bresnahan
Grizzly
Fix Released
Low
John Bresnahan

Bug Description

We're currently only monkey patching the `socket` module. This is a problem b/c we make numerous calls to `time.sleep` which block (and who knows what else?).

This patch follows the `nova` pattern of monkey patching everything. A similar patch will need to be made for Quantum which copied the monkey-patching code over from `glance`.

Changed in glance:
assignee: nobody → Rick Harris (rconradharris)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/6788

Brian Waldon (bcwaldon)
Changed in glance:
milestone: none → folsom-1
Thierry Carrez (ttx)
Changed in glance:
milestone: folsom-1 → folsom-2
Brian Waldon (bcwaldon)
Changed in glance:
importance: Medium → Low
milestone: folsom-2 → folsom-3
Revision history for this message
Brian Waldon (bcwaldon) wrote :

Are you going to have this fixed by F3?

Brian Waldon (bcwaldon)
Changed in glance:
status: In Progress → Triaged
assignee: Rick Harris (rconradharris) → nobody
milestone: folsom-3 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/11646

Changed in glance:
assignee: nobody → Brian Waldon (bcwaldon)
status: Triaged → In Progress
Brian Waldon (bcwaldon)
Changed in glance:
milestone: none → folsom-rc1
Brian Waldon (bcwaldon)
Changed in glance:
status: In Progress → Triaged
assignee: Brian Waldon (bcwaldon) → nobody
milestone: folsom-rc1 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/22753

Changed in glance:
assignee: nobody → Brian Waldon (bcwaldon)
status: Triaged → In Progress
Revision history for this message
Brian Waldon (bcwaldon) wrote :

I propose we take my patch then close this. We can open related bugs with specific modules to monkey patch.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/23044

Changed in glance:
assignee: Brian Waldon (bcwaldon) → John Bresnahan (jbresnah)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/22753
Committed: http://github.com/openstack/glance/commit/7804a6ea60500646533e4089997e3ef540400c83
Submitter: Jenkins
Branch: master

commit 7804a6ea60500646533e4089997e3ef540400c83
Author: Brian Waldon <email address hidden>
Date: Fri Feb 22 14:29:28 2013 -0800

    monkey_patch the time module for eventlet

    Fixes bug 988099

    Change-Id: I24dfe81863484ed07b77ab20f9d8ab7746e977df

Changed in glance:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/23044
Committed: http://github.com/openstack/glance/commit/9a01d5389ac3235279f75256815e23e49ebc0c6a
Submitter: Jenkins
Branch: master

commit 9a01d5389ac3235279f75256815e23e49ebc0c6a
Author: John Bresnahan <email address hidden>
Date: Mon Mar 4 09:19:55 2013 -1000

    A test for concurrency when glance uses sleep.

    Bug 988099 showed that time.sleep was not being monkey patched
    resulting in no concurrency when a sleep was called. This was
    fixed with change I24dfe818. This commit provides a regression
    test to ensure that this behavior remains in place as glance is
    developed over time.

    Change-Id: Iafbfaa9fd672b5ffd1d19a43dee03dfbfc6d3a2d

Thierry Carrez (ttx)
Changed in glance:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25188

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/25188
Committed: http://github.com/openstack/glance/commit/2ff8b9627c9c9a48af0e12b65bbbe4325d5e804c
Submitter: Jenkins
Branch: master

commit 2ff8b9627c9c9a48af0e12b65bbbe4325d5e804c
Author: John Bresnahan <email address hidden>
Date: Fri Mar 22 11:26:12 2013 -1000

    Directly verifying that time and socket are monkey patched

    This tests makes sure that thew wsgi object properly monkey patched
    two needed modules, socket and time. In bug 988099 it was noted that
    the time module was not being monkey patched. A test was added that
    unfortunately introduced a bug and a patch to revert it is here:
    https://review.openstack.org/#/c/25107/ in order to fix bug 1158247.
    This patch allows for test_server_monkey_patch.py to be removed
    without losing the verification of that functionality.

    Fixes bug 1158247
    Change-Id: I8da6b04d0cc0dae00ba52e5b7350a5e01a76cadb

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25635

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (milestone-proposed)

Reviewed: https://review.openstack.org/25635
Committed: http://github.com/openstack/glance/commit/13f8f0082faf70debb3c56e01e7492f29913e783
Submitter: Jenkins
Branch: milestone-proposed

commit 13f8f0082faf70debb3c56e01e7492f29913e783
Author: John Bresnahan <email address hidden>
Date: Fri Mar 22 11:26:12 2013 -1000

    Directly verifying that time and socket are monkey patched

    This tests makes sure that thew wsgi object properly monkey patched
    two needed modules, socket and time. In bug 988099 it was noted that
    the time module was not being monkey patched. A test was added that
    unfortunately introduced a bug and a patch to revert it is here:
    https://review.openstack.org/#/c/25107/ in order to fix bug 1158247.
    This patch allows for test_server_monkey_patch.py to be removed
    without losing the verification of that functionality.

    Fixes bug 1158247
    Change-Id: I8da6b04d0cc0dae00ba52e5b7350a5e01a76cadb

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.