Shoutcast continuously sends metadata (confuses some streambox / song history programs)

[Stefan]

Hi

I'm new in using Mixxx. I plan to send in a German Internet Radio Station. Most of the guys there are using SAM. I prefer Mixxx and I'm really happy with it. But there is a problem where I need your help.

The station is using shoutcast and a streambox generatet by http://www.ak-webdesign.net/service/sb_generator.htm .
There is also a song history shown on the site of the stataion. This is based on http://www.ak-webdesign.net/service/sh_generator.htm. Here I have the problem. There are always multiple entries of Artist and Songtitle in the list. Most of the time there are more than 10 entries of the same track. For me it looks like Mixxx is sending the information permanently out.
The guys using SAM do not have this problem. There it works fine.

Do you have an idea what I could do, to get this issue solved?

I'm using Windows7 and Mixxx 1.10.0 (build r3034)

Stefan

[RJ Skerry-Ryan (rryan)]

Hm -- looks odd. thanks Stefan.

[RJ Skerry-Ryan (rryan)]

Hi Stefan,

Are you using Ogg streaming or MP3 streaming?

[Stefan (stefan-wahlen)]

Hi Ryan

I'm using MP3.

Stefan

 RJ Ryan <email address hidden> hat geschrieben:

Hi Stefan,

Are you using Ogg streaming or MP3 streaming?

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/986981

Title:
  Shoutcast continuously sends metadata (confuses some streambox / song
  history programs)

Status in Mixxx:
  New

Bug description:
  Hi

  I'm new in using Mixxx. I plan to send in a German Internet Radio
  Station. Most of the guys there are using SAM. I prefer Mixxx and I'm
  really happy with it. But there is a problem where I need your help.

  The station is using shoutcast and a streambox generatet by http://www.ak-webdesign.net/service/sb_generator.htm .
  There is also a song history shown on the site of the stataion. This is based on http://www.ak-webdesign.net/service/sh_generator.htm. Here I have the problem. There are always multiple entries of Artist and Songtitle in the list. Most of the time there are more than 10 entries of the same track. For me it looks like Mixxx is sending the information permanently out.
  The guys using SAM do not have this problem. There it works fine.

  Do you have an idea what I could do, to get this issue solved?

  I'm using Windows7 and Mixxx 1.10.0 (build r3034)

  Stefan

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/986981/+subscriptions

[Dennis Wallace (mixxx-lp)]

I'm seeing this as well. In my testing, it appears that when the track changes, the metadata is being sent (correct) but it's the same data as the first-played track (incorrect). Maybe the $artist and $title variables are being set once and never updated?

[Dennis Wallace (mixxx-lp)]

And investigating the code in engeinshoutcast.cpp this is exactly what's happening. The original string (containing $title and $artist) is gathered when the stream opens. Then, it's replaced directly in that same string object on the first submission of the metadata. Subsequent replacements then do not work as expected as the source title and $artist have already been removed/replaced.

[Dennis Wallace (mixxx-lp)]

diff --git a/src/engine/sidechain/engineshoutcast.cpp b/src/engine/sidechain/engineshoutcast.cpp
index 1b34953..526731a 100644
--- a/src/engine/sidechain/engineshoutcast.cpp
+++ b/src/engine/sidechain/engineshoutcast.cpp
@@ -613,27 +613,31 @@ void EngineShoutcast::updateMetaData() {
                 // the references to $title and $artist by doing a single
                 // pass over the string
                 int replaceIndex = 0;
+
+ // Make a copy so we don't overwrite the references only
+ // once per streaming session.
+ QString metadataFinal = m_metadataFormat;
                 do {
                     // find the next occurrence
- replaceIndex = m_metadataFormat.indexOf(
+ replaceIndex = metadataFinal.indexOf(
                                       QRegExp("\\$artist|\\$title"),
                                       replaceIndex);

                     if (replaceIndex != -1) {
- if (m_metadataFormat.indexOf(
+ if (metadataFinal.indexOf(
                                           QRegExp("\\$artist"), replaceIndex)
                                           == replaceIndex) {
- m_metadataFormat.replace(replaceIndex, 7, artist);
+ metadataFinal.replace(replaceIndex, 7, artist);
                             // skip to the end of the replacement
                             replaceIndex += artist.length();
                         } else {
- m_metadataFormat.replace(replaceIndex, 6, title);
+ metadataFinal.replace(replaceIndex, 6, title);
                             replaceIndex += title.length();
                         }
                     }
- } while (replaceIndex != -1);
+ } while (replaceIndex != -1);

- QByteArray baSong = encodeString(m_metadataFormat);
+ QByteArray baSong = encodeString(metadataFinal);
                 shout_metadata_add(m_pShoutMetaData, "song", baSong.constData());
             }
             shout_set_metadata(m_pShout, m_pShoutMetaData);

[Dennis Wallace (mixxx-lp)]

Pull request submitted.

[jus (jus)]

https://github.com/mixxxdj/mixxx/commit/215281a3df16ef85d5271aafb388d30e6bdd757a

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6376